Update TwitterKit with new circle user image and iPhone X support?

JEK_ZZ · 2017-09-14T22:09:36.182Z

Hi,
Is it on your plans to update TwitterKit for iOS and Android with the new circle user image like the new twitter design, and also add support for iPhone X ? I saw the close button (X) on imageViewer is not on safe Area as Apple guidelines suggest.

Do you have TwitterKit iOS sdk on github?
I can do the changes by myself and create a pull request if you want.

katejaiheelee · 2017-09-18T23:17:04.648Z

Adapting the new design for Twitter Kit and open-sourcing iOS SDK are in plan.
We are aware of the image viewer bug, and will have fix for next release.

JEK_ZZ · 2017-10-31T12:26:22.349Z

iPhone X will be released in 3 days from now, new TwitterKit version is coming sooner?

itsrealannjawn · 2017-11-14T04:24:19.727Z

@katejaiheelee would really like to know when the next release can be expected. The image viewer bug is pretty annoying since it forces the user to kill the app and relaunch. Accidental taps on images by iPhone X users can cause a pretty bad user experience…

Tw1Mate · 2017-12-13T15:38:01.290Z

You said “We are aware of the image viewer bug, and will have fix for next release” when version of TwitterKit is 3.2.1.
TwitterKit 3.2.2 is released.
But nothing fixed.
Would you please fix this bug sooner.

JEK_ZZ · 2017-12-16T00:11:16.644Z

The iPhone X support does not exist on TwitterKit 3.3.0. See below how to fix this thing with the overlapping of statusbar.

JEK_ZZ · 2017-12-19T14:50:18.147Z

TwitterKit iOS SDK is on github

JosephLordUK · 2018-01-17T17:15:35.185Z

Yes 3.3 is on GitHub but it doesn’t seem to fix the image (and video) viewer bug on iPhone X in portrait. I spent considerable time today getting the Github version built because the version on your developer site for manual install wasn’t updated (I’ve since found another thread with a link to built version of 3.3) only to discover it doesn’t fix this issue properly.

JEK_ZZ · 2018-01-17T17:48:13.925Z

add View controller-based status bar appearance to YES on Info.plist to fix the problem with the overlapping of statusbar over the X button

JosephLordUK · 2018-01-18T14:09:56.516Z

Thanks, that worked.

bonkey · 2018-02-05T17:14:38.382Z

Worked for me, too. Unfortunately, I spotted another issue with video seeking:

Video seek on iPhone X conflicts with home button Twitter Kit SDK

Seeking in full-screen video is almost unusable on iPhone X: Just reporting for now, but I’ll look for some solutions, including fixing it one day :slight_smile: However, maybe someone has an idea what to do with it?