TwitterKit is dismissing callee controller in airplane mode

[TT_Kilew]

Consider this example

  let controller = /** Some modal controller */

 Twitter.sharedInstance().logIn(with: controller, completion: { (session, error) -> Void in
  })

If there’s no/bad internet connection /airplane mode, TwitterSDK will dismiss the controller immediately

Here are some call stacks which are showing that this call is made by the TwitterSDK itself

Potentially related issues:

TwitterKit dismisses my viewcontroller after cancelling to log in

I am using Twitter.sharedInstance.logInWithCompletion to log in. My view controller is dismissed unexpectedly, when I press cancel button at the timing of screenshot attached. This occurs in TwitterKit iOS(1.12.0). [image]

[HaikuDennis]

I’m having similar trouble- TwitterKit is dismissing my (modally presented) view controller which is invoking -[Twitter loginWithCompletion:] when the user cancels authentication in the SFSafariViewController via the ‘Done’ button.

iOS 11 & 10, Xcode 9b6 & 8.3.3
TwitterKit 3.1.1

Steps:

1. My (modally presented) View Controller calls [[Twitter sharedInstance] loginWithCompletion:...]
2. SFSafariViewController is presented to handle auth (simulator / no Twitter app)
3. User taps Done in nav bar (cancels auth)
4. My view controller is sent -dismissViewControllerAnimated:completion: from TwitterKit!

See backtrace:

* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 22.1
  * frame #0: 0x000000010fc4bfd2 Redacted`-[LoginViewController dismissViewControllerAnimated:completion:](self=0x00007fb64c9990b0, _cmd="dismissViewControllerAnimated:completion:", flag=YES, completion=(null)) at LoginViewController.m:78
    frame #1: 0x0000000110204036 Redacted`__43-[Twitter performWebBasedLogin:completion:]_block_invoke.275 + 70
    frame #2: 0x00000001101d0235 Redacted`-[TWTRWebAuthenticationFlow failWithError:] + 104
    frame #3: 0x00000001101d0031 Redacted`__68-[TWTRWebAuthenticationFlow presentWebAuthenticationViewController:]_block_invoke + 65
    frame #4: 0x00000001101eb74d Redacted`-[TWTRWebAuthenticationViewController failWithError:] + 282
    frame #5: 0x00000001101eb519 Redacted`-[TWTRWebAuthenticationViewController safariViewControllerDidFinish:] + 64
    frame #6: 0x0000000113b49b95 SafariServices`-[SFSafariViewController remoteViewControllerWillDismiss:] + 128
    frame #7: 0x0000000113b3bb1d SafariServices`-[SFBrowserRemoteViewController willDismissServiceViewController] + 47

From searching the forums it looks like similar problems have occurred in previous releases of TwitterKit.

Edit: It appears performWebBasedLogin:completion: is attempting to dismiss the SFSafariViewController on Done, but I suspect this is already handled by the SafariServices framework.

Please help!

[Bug][TwitterKit][iOS] - SFSafariViewController login dismisses my view controller

Hey, I'm experiencing an issue where i'm using the TwitterKit SDK to sign in via the .WebBased or .WebBasedForceLogin methods however when the logInWithViewController(viewController: UIViewController?, methods: TWTRLoginMethod, completion: TWTRLogInCompletion) method completes, it seems to dismiss my own view controllers that are presented too. I'm using TwitterKit 2.2.0 installed via Cocoapods (no fabric stuff). Here is the view controller hierarchy prior to interacting with the TwitterS…

TwitterKit dismisses my viewcontroller after cancelling to log in

I am using Twitter.sharedInstance.logInWithCompletion to log in. My view controller is dismissed unexpectedly, when I press cancel button at the timing of screenshot attached. This occurs in TwitterKit iOS(1.12.0). [image]

TwitterKit (iOS) dismisses app’s top viewcontroller unexpectedly

TwitterKit (iOS) v1.10.0+ dissmisses app's top viewcontroller unexpectedly. Steps to reproduce: 1. Deny app's request to access Twitter accounts (or Remove all accounts from the iOS device.) 2. Turn "Airplane Mode" on. 3. Invoke -[Twitter logInWithCompletion:] Why https://twittercommunity.com/t/twitterkit-ios-dismisses-apps-top-viewcontroller-unexpectedly/54291 issue was closed? Seems not fixed yet...

[Bug] TWTRLoginMethod.WebBased Login causes unexpected ViewController dismiss when network is unconnectable

We encountered following issue. present(modal) Controller. call "Twitter.sharedInstance().logInWithViewController(controller, methods: TWTRLoginMethod.WebBased)" on Presenting Controller if network is unconnectable, Presenting Controller was dismissed unfortunately. (do "1. 2." next "3." is caused) Is this bug? or Can we avoid this unexpected dissmiss? thank you for your help.

[andriajensen]

Seeing the same thing. I tried passing nil as the viewController, or use the logIn method without a viewController parameter and had the same result.

[LyTrungVinh]

I’m having the same issue, please help !

[Revolt]

Same

[BtcSk]

This is happening to me, the callee viewController is being dismissed if the app is not installed. Steps to reproduce:

1. Make sure Twitter is no installed
2. Call Twitter.sharedInstance().logIn(with: viewController)

TwitterKit logs the message and closes the callee vie controller:

<hash>
  <error>Desktop applications only support the oauth_callback value 'oob'</error>
  <request>/oauth/request_token</request>
</hash>
" UserInfo={NSLocalizedDescription=<?xml version="1.0" encoding="UTF-8"?>
<hash>
  <error>Desktop applications only support the oauth_callback value 'oob'</error>
  <request>/oauth/request_token</request>
</hash>
}

[pavan_gopal39]

having the same issue …anyone got around it?
Im using TwitterKit 3

[vanicous]

Having the same issue and it’s driving me crazy.

[JZjzJzJZzzzJ]

Seeing the same/similar thing right now. I am using TWTRComposerViewController, and on user tapping cancel in the UI, the calling vc is dismissed. It doesn’t happen if the calling vc is not presented modally.

[timvermeulen]

This issue doesn’t seem to be fixed yet, is there a workaround?

[DevSN2]

Using latest twiiterkit, but still facing the same issue.
Twitter team, please solve this as soon as possible.

[KerberMenvia]

I’m having the same issue too.
Since TwitterKit is being discontinuated I think the best solution is to migrate to using the Twitter’s standard API itself or as a quick workaround try to check if Twitter app is installed on the device before calling the login.

[andypiper]

I would certainly support the suggestion to migrate to an alternative solution.