Native Ads bug

YanbinHung · 2017-04-13T09:02:02.025Z

Please read the following code : line 408

mopub/mopub-android-sdk/blob/940eee70fe1980b4869d61cb5d668ccbab75c0ee/mopub-sdk/mopub-sdk-native-static/src/main/java/com/mopub/nativeads/MoPubRecyclerAdapter.java

package com.mopub.nativeads;

import android.app.Activity;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
import android.support.v7.widget.LinearLayoutManager;
import android.support.v7.widget.RecyclerView;
import android.view.View;
import android.view.ViewGroup;

import com.mopub.common.Preconditions;
import com.mopub.common.VisibleForTesting;
import com.mopub.common.logging.MoPubLog;
import com.mopub.nativeads.MoPubNativeAdPositioning.MoPubClientPositioning;
import com.mopub.nativeads.MoPubNativeAdPositioning.MoPubServerPositioning;

import java.util.List;
import java.util.WeakHashMap;

import static com.mopub.nativeads.MoPubRecyclerAdapter.ContentChangeStrategy.INSERT_AT_END;

This file has been truncated. show original

There’s no need to cast from ‘Context’ to ‘Activity’ !!!
It will crash when I use RecycleView in DialogFragment !!!

chauduyphanvu · 2017-04-20T19:25:30.676Z

Hey @YanbinHung, thanks for the suggestion! I’ll relay this to our SDK Engineering team for further consideration.

In the meantime, could you send over a minimal sample that reproduces the crash?

Cheers.